fix: avoid using bigint literal syntax (#542)

mman · web-flow · commit c14d358e94d6 · 2024-12-19T00:15:42.000-08:00
* fix: avoid using bigint literal syntax

* simplify

* fix: Add custom eslint plugin with no-big-int rule

* fix: Migrate .eslintrc.js to flat format eslint.config.mjs

* fix(gh): exclude node 12.x, 14.x on macos-latest
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/.github/workflows/bundlers.yml b/.github/workflows/bundlers.yml
@@ -20,6 +20,10 @@ jobs:
             node-version: 12.x
           - os: windows-latest
             node-version: 14.x
+          - os: macos-latest
+            node-version: 12.x
+          - os: macos-latest
+            node-version: 14.x
     steps:
       - name: Checkout
         uses: actions/checkout@v3
diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml
@@ -19,6 +19,10 @@ jobs:
             node-version: 12.x
           - os: windows-latest
             node-version: 14.x
+          - os: macos-latest
+            node-version: 12.x
+          - os: macos-latest
+            node-version: 14.x
     steps:
       - name: Checkout
         uses: actions/checkout@v3
diff --git a/eslint-plugin-local/index.mjs b/eslint-plugin-local/index.mjs
@@ -0,0 +1,9 @@
+'use strict'
+
+import nbi from './no-big-int.mjs'
+
+export default {
+    rules: {
+        'no-big-int': nbi,
+    },
+}
diff --git a/eslint-plugin-local/no-big-int.mjs b/eslint-plugin-local/no-big-int.mjs
@@ -0,0 +1,26 @@
+'use strict'
+
+export default {
+    meta: {
+        docs: {
+            description: 'disallow `bigint` syntax',
+            category: 'ES2020',
+            recommended: false,
+        },
+        fixable: null,
+        messages: {
+            forbidden: 'ES2020 `bigint` syntax is forbidden.',
+        },
+        schema: [],
+        type: 'problem',
+    },
+    create(context) {
+        return {
+            Literal(node) {
+                if (node.bigint != null) {
+                    context.report({ messageId: 'forbidden', node })
+                }
+            },
+        }
+    },
+}
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,27 @@
+import { FlatCompat } from '@eslint/eslintrc'
+const compat = new FlatCompat()
+
+import eslintPluginLocal from './eslint-plugin-local/index.mjs'
+
+export default [
+  // standard,
+  ...compat.extends('eslint-config-standard'),
+  {
+    files: ['**/**.js', '**/**.mjs'],
+    languageOptions: {
+      sourceType: 'module',
+      ecmaVersion: 'latest',
+    },
+    plugins: { 'local': eslintPluginLocal },
+    rules: {
+      /*
+        This is inserted to make this compatible with prettier.
+        Once https://github.com/prettier/prettier/issues/3845 and https://github.com/prettier/prettier/issues/3847 are solved this might be not needed any more.
+      */
+      'space-before-function-paren': 0,
+      curly: [2, 'all'],
+      'local/no-big-int': 'error',
+    },
+  },
+]
+
diff --git a/src/errors.js b/src/errors.js
@@ -335,8 +335,8 @@ E(
       received = addNumericalSeparator(String(input))
     } else if (typeof input === 'bigint') {
       received = String(input)
-
-      if (input > 2n ** 32n || input < -(2n ** 32n)) {
+      const limit = BigInt(2) ** BigInt(32)
+      if (input > limit || input < -limit) {
         received = addNumericalSeparator(received)
       }
 
