This repository was archived by the owner on Aug 11, 2020. It is now read-only.
quic: remove namespace qualifier for SecureContext#368
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:crypto-securecontext-ns
Closed
quic: remove namespace qualifier for SecureContext#368danbev wants to merge 1 commit intonodejs:masterfrom danbev:crypto-securecontext-ns
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:crypto-securecontext-ns
Conversation
Currently, there are a few locations where the crypto namespace is used explicitly for SecureContext even though there is a using declaration for SecureContext. This commit removes the explict ones to make the code consistent.
addaleax
approved these changes
Apr 15, 2020
jasnell
approved these changes
Apr 15, 2020
danbev
added a commit
that referenced
this pull request
Apr 16, 2020
Currently, there are a few locations where the crypto namespace is used explicitly for SecureContext even though there is a using declaration for SecureContext. This commit removes the explict ones to make the code consistent. PR-URL: #368 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
Author
|
Landed in 0eed19b. |
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
Currently, there are a few locations where the crypto namespace is used explicitly for SecureContext even though there is a using declaration for SecureContext. This commit removes the explict ones to make the code consistent. PR-URL: nodejs#368 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
splitice
pushed a commit
to HalleyAssist/quic
that referenced
this pull request
May 13, 2020
Currently, there are a few locations where the crypto namespace is used explicitly for SecureContext even though there is a using declaration for SecureContext. This commit removes the explict ones to make the code consistent. PR-URL: nodejs#368 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are a few locations where the crypto namespace is used
explicitly for SecureContext even though there is a using declaration
for SecureContext. This commit removes the explict ones to make the code
consistent.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes