Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/postject
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c8e096a
Choose a base ref
...
head repository: nodejs/postject
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3534343
Choose a head ref
  • 10 commits
  • 13 files changed
  • 1 contributor

Commits on Oct 20, 2022

  1. chore: add LIEF's LICENSE (#55)

    Refs: nodejs/node#45066 (comment)
    Signed-off-by: Darshan Sen <[email protected]>
    
    Signed-off-by: Darshan Sen <[email protected]>
    RaisinTen authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    1f1d160 View commit details
    Browse the repository at this point in the history
  2. fix: make sure that postject-api.h compiles without warnings (#54)

    * fix: make sure that postject-api.h compiles without warnings
    
    Fixes the following error I came across while integrating Postject in
    Node.js:
    ```console
    ../deps/postject/src/dist/postject-api.h:30:13: error: unused function 'postject_options_init' [-Werror,-Wunused-function]
    static void postject_options_init(struct postject_options* options) {
                ^
    1 error generated.
    ```
    
    Refs: nodejs/node#45038
    Signed-off-by: Darshan Sen <[email protected]>
    
    * fix: resolve another compiler warning
    
    ```console
    In file included from /root/project/test/test.c:4:
    /root/project/test/../dist/postject-api.h: In function 'postject_find_resource':
    /root/project/test/../dist/postject-api.h:96:9: error: unused variable 'ptr' [-Werror=unused-variable]
       96 |   void* ptr = NULL;
          |         ^~~
    cc1: all warnings being treated as errors
    ```
    
    Refs: https://app.circleci.com/pipelines/github/postmanlabs/postject/180/workflows/d0eb47c0-5482-4c85-9c63-aa854ddb0221/jobs/1398?invite=true#step-110-678
    Signed-off-by: Darshan Sen <[email protected]>
    
    * fix: use -Wall -WX on Windows
    
    Signed-off-by: Darshan Sen <[email protected]>
    
    * chore: use -W4 instead of -Wall
    
    -Wall produces too many warnings.
    
    Refs: https://app.circleci.com/pipelines/github/postmanlabs/postject/185/workflows/48b0f126-8000-41d9-b39e-cb8b9e4bc9d6/jobs/1441?invite=true#step-107-693
    Signed-off-by: Darshan Sen <[email protected]>
    
    * fix: another compilation warning on Windows
    
    ```console
    C:\Users\circleci\project\test\../dist/postject-api.h(153,5): error C2220: the following warning is treated as an error [C:\Users\circleci\project\build\test\c_test.vcxproj]
    C:\Users\circleci\project\test\../dist/postject-api.h(153,5): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\Users\circleci\project\build\test\c_test.vcxproj]
    C:\Users\circleci\project\test\test.c(13,5): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\Users\circleci\project\build\test\c_test.vcxproj]
    ```
    
    Refs: https://app.circleci.com/pipelines/github/postmanlabs/postject/186/workflows/f1389b9f-c958-4a24-9d6e-28af856ff776/jobs/1455?invite=true#step-107-694
    Signed-off-by: Darshan Sen <[email protected]>
    
    * fix: compiler warning on Windows
    
    ```console
    C:\Users\circleci\project\test\test.c(13,5): error C2220: the following warning is treated as an error [C:\Users\circleci\project\build\test\c_test.vcxproj]
    C:\Users\circleci\project\test\test.c(13,5): warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [C:\Users\circleci\project\build\test\c_test.vcxproj]
    ```
    
    Refs: https://app.circleci.com/pipelines/github/postmanlabs/postject/187/workflows/8bcdcb96-646d-4008-93bf-294e92469b3d/jobs/1464?invite=true#step-107-694
    Signed-off-by: Darshan Sen <[email protected]>
    
    * fix: use -EHsc for test.cpp
    
    ```console
    C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\ostream(743,1): error C2220: the following warning is treated as an error [C:\Users\circleci\project\build\test\cpp_test.vcxproj]
    C:\Users\circleci\project\test\test.cpp(13): message : see reference to function template instantiation 'std::basic_ostream<char,std::char_traits<char>> &std::operator <<<std::char_traits<char>>(std::basic_ostream<char,std::char_traits<char>> &,const char *)' being compiled [C:\Users\circleci\project\build\test\cpp_test.vcxproj]
    C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\include\ostream(743,1): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc [C:\Users\circleci\project\build\test\cpp_test.vcxproj]
    ```
    
    Refs: https://app.circleci.com/pipelines/github/postmanlabs/postject/188/workflows/9107adc5-61a3-41ad-bd60-dd3eb0996765/jobs/1470?invite=true#step-107-696
    Signed-off-by: Darshan Sen <[email protected]>
    
    * fix: use / instead of - for Windows compiler options
    
    Signed-off-by: Darshan Sen <[email protected]>
    
    * chore: use target_compile_options instead of set
    
    Signed-off-by: Darshan Sen <[email protected]>
    
    Signed-off-by: Darshan Sen <[email protected]>
    RaisinTen authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    b9356bf View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. docs: make postject ready for transferring to the nodejs org (#57)

    This change adds a CODE_OF_CONDUCT.md file and a CONTRIBUTING.md file to
    the project. This is a requirement for transferring as documented in: https://github.com/nodejs/admin/blob/a99c444662467d596753affb2ce192250f4f4b6c/transfer-repo-into-the-org.md#step-1-get-the-repository-ready.
    
    Refs: nodejs/admin#739
    Signed-off-by: Darshan Sen <[email protected]>
    
    Signed-off-by: Darshan Sen <[email protected]>
    RaisinTen authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    30e9a23 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. test: add test for code signing on macOS (#52)

    Signed-off-by: Darshan Sen <[email protected]>
    
    Signed-off-by: Darshan Sen <[email protected]>
    RaisinTen authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    0b89222 View commit details
    Browse the repository at this point in the history
  2. chore: remove Postman copyright from postject-api.h (#60)

    chore: remove Postman copyright from postject-api.h
    
    No need for it.
    
    Refs: nodejs/node#45038 (comment)
    Signed-off-by: Darshan Sen <[email protected]>
    
    Signed-off-by: Darshan Sen <[email protected]>
    RaisinTen authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    2f858f7 View commit details
    Browse the repository at this point in the history
  3. test: remove Node.js specific tests (#61)

    It doesn't make sense to test just the resource injection part on a
    program that doesn't use the runtime API by calling any of the functions
    inside postject-api.h.
    
    Refs: #59 (comment)
    Signed-off-by: Darshan Sen <[email protected]>
    
    Signed-off-by: Darshan Sen <[email protected]>
    RaisinTen authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    dfb7a70 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. fix: compilation error on macOS >= 13 (#69)

    Fixes: #68
    Signed-off-by: Darshan Sen <[email protected]>
    RaisinTen authored Jan 5, 2023
    Configuration menu
    Copy the full SHA
    30989e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Configuration menu
    Copy the full SHA
    f6b171c View commit details
    Browse the repository at this point in the history
  2. release: 1.0.0-alpha.4

    Signed-off-by: Darshan Sen <[email protected]>
    RaisinTen committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    3534343 View commit details
    Browse the repository at this point in the history
Loading