Skip to content

fix: some broken links at collaborator guide#6426

Merged
ovflowd merged 3 commits intonodejs:mainfrom
mahmudhmh:main
Mar 4, 2024
Merged

fix: some broken links at collaborator guide#6426
ovflowd merged 3 commits intonodejs:mainfrom
mahmudhmh:main

Conversation

@mahmudhmh
Copy link
Copy Markdown
Contributor

@mahmudhmh mahmudhmh commented Mar 4, 2024 •
edited
Loading

there were some broken links and fixed them in the collaborator guide @ovflowd @AugustinMauroy

@mahmudhmh mahmudhmh requested a review from a team as a code owner March 4, 2024 08:36
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 4, 2024 4:31pm

@mahmudhmh mahmudhmh changed the title Main fix: some broken links at collaborator guide Mar 4, 2024
@mahmudhmh mahmudhmh mentioned this pull request Mar 4, 2024
Closed
AugustinMauroy
AugustinMauroy reviewed Mar 4, 2024
View reviewed changes
Comment thread COLLABORATOR_GUIDE.md Outdated
@AugustinMauroy
Copy link
Copy Markdown
Member

AugustinMauroy commented Mar 4, 2024

Other point you are not obligated to ping us we are already ping with the code owner

ovflowd
ovflowd reviewed Mar 4, 2024
View reviewed changes
Comment thread COLLABORATOR_GUIDE.md Outdated
ovflowd
ovflowd requested changes Mar 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is changing links that aren't broken.

@mahmudhmh
Copy link
Copy Markdown
Contributor Author

mahmudhmh commented Mar 4, 2024

I've added the next-intl definition referenced with the npm link

[`next-intl`]: https://www.npmjs.com/package/next-intl

@bmuenzenmeyer
Copy link
Copy Markdown
Contributor

bmuenzenmeyer commented Mar 4, 2024

now the remaining react-intl references should be replaced with your new next-intl reference, right?

@mahmudhmh
Copy link
Copy Markdown
Contributor Author

mahmudhmh commented Mar 4, 2024

now the remaining react-intl references should be replaced with your new next-intl reference, right?

no, I'm just adding the reference to the next-intl one, not the react-intl which was already working

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Mar 4, 2024

Thanks for the first-time contribution! And for making updates to the requested changes!

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 4, 2024
@github-actions github-actions Bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 90 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 92 🟢 100 🟢 92 🔗

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Mar 4, 2024

I'm fast-tracking this as a simple fix.

@ovflowd ovflowd enabled auto-merge March 4, 2024 20:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
 80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.71s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Mar 4, 2024
@mahmudhmh
Copy link
Copy Markdown
Contributor Author

mahmudhmh commented Mar 4, 2024

Thanks for the first-time contribution! And for making updates to the requested changes!

Thank you sm, and sorry for the conflict at the beginning

Merged via the queue into nodejs:main with commit 5380385 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy left review comments

@ovflowd ovflowd ovflowd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mahmudhmh @AugustinMauroy @bmuenzenmeyer @ovflowd