fix some typos and enhance 'advanced' knowledge files · Pull Request #2909 · nodejs/nodejs.org

ghost · 2020-01-24T07:51:32Z

Fixtures for some typos.
Add 'console' for some console codes to enhance the formation.
Add some backquotes onto some methods.

1. Fixtures for some typos. 2. Add 'bash' for some console codes to enhance the formation. 3. Add some backquotes onto some methods. 4. For Buffer, we have a outdated (obsolated) method before v8.0.0, we refer it for historical reason with some warning messages.

Add missing comments

Trott · 2020-01-26T02:27:43Z

If this PR stalls at some point, it would be good to get a PR that just gets rid of the new Buffer() examples. That would likely be approved and merged very quickly.

ghost · 2020-01-26T03:29:51Z

If this PR stalls at some point, it would be good to get a PR that just gets rid of the new Buffer() examples. That would likely be approved and merged very quickly.

Agreed, so my change updated 'new Buffer' to 'Buffer.alloc'.

nschonni

Might be good to squash and fix the commit message when landing

XhmikosR · 2020-01-30T10:40:21Z

This shouldn't have landed with console as a syntax highlighting language. It's unknown to prism.js thus it leads to wrong highlighting.

I'll make a PR to remove it.

XhmikosR · 2020-01-30T10:44:16Z

We really need PR previews. Also this was sort of showing in the CI build, but it didn't mark it as failed: https://github.com/nodejs/nodejs.org/runs/414306542#step:8:31

We might need to fork metalsmith-prism since the package is archived.

ghost requested a review from XhmikosR January 24, 2020 07:53

add more comments

fa9bbc2

Add missing comments

ghost changed the title ~~fixtures some typos and enhance the knowledge files~~ fixtures some typos and enhance 'advanced' knowledge files Jan 24, 2020

ghost self-requested a review January 24, 2020 08:35

XhmikosR changed the title ~~fixtures some typos and enhance 'advanced' knowledge files~~ fix some typos and enhance 'advanced' knowledge files Jan 24, 2020

XhmikosR reviewed Jan 24, 2020

View reviewed changes

Comment thread locale/en/knowledge/advanced/buffers/how-to-use-buffers.md Outdated

Comment thread locale/en/knowledge/advanced/streams/how-to-use-fs-create-read-stream.md Outdated

Comment thread locale/en/knowledge/advanced/streams/how-to-use-stream-pipe.md Outdated

Update how-to-use-stream-pipe.md

0af2695