Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

feature: added calendar page#2900

Closed
benhalverson wants to merge 9 commits intonodejs:mainfrom
benhalverson:feat/gcal
Closed

feature: added calendar page#2900
benhalverson wants to merge 9 commits intonodejs:mainfrom
benhalverson:feat/gcal

Conversation

@benhalverson
Copy link
Copy Markdown
Member

Description

Uses the google calendar API to display the public events from the nodejs calendar.

Related Issues

#883

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Oct 10, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Oct 10, 2022
@github-actions
Copy link
Copy Markdown

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Oct 10, 2022

Nice! Excited to finally get this going :yay:

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Oct 10, 2022

@ovflowd ovflowd mentioned this pull request Oct 10, 2022
@AugustinMauroy
Copy link
Copy Markdown
Member

I propose that a link is available in the header nav.
What do you think about it? 👍👎

@benhalverson
Copy link
Copy Markdown
Member Author

I was thinking the about page somewhere but the header could also work

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Oct 11, 2022

I propose that a link is available in the header nav.
What do you think about it? 👍👎

We don't want to add way too many stuff on header... Otherwise it gets bloated...

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Oct 11, 2022

Also too many entries on header will break the style on small desktop screens or tablets.

@benhalverson benhalverson deleted the feat/gcal branch December 16, 2022 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants