Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

chore(dependencies): switched to safest newest dependencies#2610

Merged
ovflowd merged 1 commit intonodejs:mainfrom
ovflowd:chore/upgrade-dependencies
Aug 5, 2022
Merged

chore(dependencies): switched to safest newest dependencies#2610
ovflowd merged 1 commit intonodejs:mainfrom
ovflowd:chore/upgrade-dependencies

Conversation

@ovflowd
Copy link
Copy Markdown
Member

@ovflowd ovflowd commented Aug 3, 2022

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build and npm run build-storybook work fine.
  • I've covered new added functionality with unit tests if necessary.

Description

This PR updates multiple dependencies to their latest safe versions, upgrades some dependencies, and removes others. There's also been some optimization to our package.json such as:

Major Changes

  • Changed ^ to ~ for some dependencies only one minor version upgrades are safe
  • Moved some dependencies from dependencies to devDependencies as they are only devDependencies
  • Removed the gatsby-plugin-react-helmet as Gatsby itself now supersedes it
  • Upgraded Storybook to version 7 as it is blazingly faster and fixed a bug introduced in Gatsby 4.19 regarding attempting to use react-dom/client (which is only compatible with Reac v18) on our environment that is locked on v16.
  • Reorganised our eslint configuration (No actual changes were done, besides alphabetization of the document and adding the StoryBook ESlint plugin)
  • Upgraded to Gatsby v4.20
  • Upgraded the package.json versions to reflect what package-lock.json is installing
  • Added ^ to some packages in devDependencies that were fixed to a specific version
  • Upgrade to React and ReactDOM v18
  • Added forced resolution for mdx/react to support react 18
  • Added temporary resolutions for Storybook Alpha 7
  • Switched to a different Dark Theme plugin that supports React 18.
  • Updated Jest to ignore the .cache folder
  • Rebuilt the Package Lock file

Miscellaneous

  • Updated Dark Mode Toggle Tests
  • Updated Jest Snaphosts

Related Issues

No related issue.

@ovflowd ovflowd added enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 3, 2022
@ovflowd ovflowd changed the title chorre(dependencies): switched to safest newest dependencies chore(dependencies): switched to safest newest dependencies Aug 3, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2610 (ef3d7c9) into main (1cf5a68) will decrease coverage by 0.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2610      +/-   ##
==========================================
- Coverage   90.38%   90.04%   -0.35%     
==========================================
  Files          87       87              
  Lines         998      994       -4     
  Branches      270      271       +1     
==========================================
- Hits          902      895       -7     
- Misses         96       99       +3     
Impacted Files Coverage Δ
src/components/Header/index.tsx 100.00% <100.00%> (ø)
src/components/Article/index.tsx 91.89% <0.00%> (-8.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf5a68...ef3d7c9. Read the comment docs.

@ovflowd
Copy link
Copy Markdown
Member Author

ovflowd commented Aug 3, 2022

Little fluff: Storybook now takes less than 10 seconds to build 🎉

And Gatsby is also way faster now.

Copy link
Copy Markdown
Member

@benhalverson benhalverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benhalverson
Copy link
Copy Markdown
Member

Can you fix the conflicts? @ovflowd

@ovflowd
Copy link
Copy Markdown
Member Author

ovflowd commented Aug 5, 2022

@benhalverson yup I will today 😄

chore(react): upgrade to react 18 and forced compatibility

fix(jest): fix jest reading cache folder

chore(tests): updated tests for dark theme

chore(snapshots): updated snapshots

chore(storybook): remove deprecated parts and removed unnecessary override
@ovflowd ovflowd force-pushed the chore/upgrade-dependencies branch from 6cb40d4 to 1f41462 Compare August 5, 2022 12:24
@ovflowd ovflowd merged commit b5ce031 into nodejs:main Aug 5, 2022
@ovflowd ovflowd deleted the chore/upgrade-dependencies branch August 5, 2022 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants