Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Node.js calendar#2428

Closed
benhalverson wants to merge 91 commits intonodejs:mainfrom
benhalverson:node-calendar
Closed

Node.js calendar#2428
benhalverson wants to merge 91 commits intonodejs:mainfrom
benhalverson:node-calendar

Conversation

@benhalverson
Copy link
Copy Markdown
Member

Description

re-Implementing the nodejs calendar that @lancemccluskey created.

Lance McCluskey and others added 30 commits August 9, 2021 06:06
dependabot bot and others added 17 commits August 2, 2022 13:35
)

chore(react): upgrade to react 18 and forced compatibility

fix(jest): fix jest reading cache folder

chore(tests): updated tests for dark theme

chore(snapshots): updated snapshots

chore(storybook): remove deprecated parts and removed unnecessary override
@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Aug 6, 2022

Something feels wrong with the rebase, it's saying this PR has 90 commits?

Maybe you should squash the original calendar commits of this PR and drop all the other commits, and then rebase. It would make the whole process less painful, no?

@benhalverson
Copy link
Copy Markdown
Member Author

ya I tried to reset to when I started this PR rebased your changes then pulled in the calendar changes.

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Aug 6, 2022

Yeah, but still @benhalverson it looks like on the commits tab, the whole history is still here... If you want, I could try to fix the tree of this branch for you 😄

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Aug 6, 2022

And also regarding the peerDependencies conflict, you can use the overrides option of package.json. Something like:

{
  ....
  "overrides": {
    "react-big-calendar": {
      "react": "$react"
    }
  }
}

@benhalverson
Copy link
Copy Markdown
Member Author

If you want, I could try to fix the tree of this branch for you 😄

If you don't mind. I'm ok with it 👍🏻

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2022

This pull request is stale because it has been open for 30 days with no activity.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2022

This pull request is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Oct 9, 2022
@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Oct 10, 2022

I'm closing this PR in favour of #2900

@ovflowd ovflowd closed this Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants