This repository was archived by the owner on Apr 22, 2023. It is now read-only.
net: make Server.prototype.unref() persistent#8966
Closed
cjihrig wants to merge 1 commit intonodejs:v0.12from
cjihrig:server-unref
Closed
net: make Server.prototype.unref() persistent#8966cjihrig wants to merge 1 commit intonodejs:v0.12from cjihrig:server-unref
cjihrig wants to merge 1 commit intonodejs:v0.12from
cjihrig:server-unref
Conversation
Currently, the unref() method does not remember any state if called before the server's handle has been created. This commit adds state to track calls to ref() and unref().
|
This looks like it should be targeted at v0.10 as a bug fix, are there other places this is true -- for instance in dgram? |
Author
|
Closing in favor of #9115. @tjfontaine Regarding dgram - the following code prints 'bound' and then exits. Removing the var dgram = require('dgram');
var socket = dgram.createSocket('udp4');
socket.unref();
socket.bind(8000, function() {
console.log('bound');
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
unref()method does not remember any state if called before the server's handle has been created. This commit adds state to track calls toref()andunref().Related to #7077. Note - a similar fix is possible for
Socket.prototype.unref()(which I have code for). However,Socketappears to have additionalunref()issues other than persistence.