This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Add missing GlobalSign root certificate which supports more secure sha25...#8679
Closed
dodtsair wants to merge 1 commit intonodejs:v0.10.25-releasefrom
dodtsair:add-globalsign-sha256
Closed
Add missing GlobalSign root certificate which supports more secure sha25...#8679dodtsair wants to merge 1 commit intonodejs:v0.10.25-releasefrom dodtsair:add-globalsign-sha256
dodtsair wants to merge 1 commit intonodejs:v0.10.25-releasefrom
dodtsair:add-globalsign-sha256
Conversation
…a256 algorithm. Global Sign has three relevant root certificates: GlobalSign Root R1 GlobalSign Root R2 GlobalSign Root R3 Both R1 and R2 are present, but R3 is missing. R3 is the more secure root certificate authority that uses SHA256 instead of the degrading SHA1. The root certificate list should be fixed to include all three Global Sign Root certificates. See article about SHA1's degrading viability as a secure hash algorithm: https://www.schneier.com/blog/archives/2005/02/cryptanalysis_o.html For validation here is the source of the certificate: https://support.globalsign.com/customer/portal/articles/1426602-globalsign-root-certificates
indutny
added a commit
to indutny/node
that referenced
this pull request
Nov 11, 2014
NOTE: To reproduce/update this - run: 1. `perl tools/mk-ca-bundle.perl` 2. `node tools/rebuild-root-certs.js ca-bundle.crt > src/node_root_certs.h` 3. `rm ca-bundle.crt certdata.txt` fix nodejs#8679
indutny
added a commit
to indutny/node
that referenced
this pull request
Nov 11, 2014
NOTE: To reproduce/update this - run: 1. `perl tools/mk-ca-bundle.perl` 2. `node tools/rebuild-root-certs.js ca-bundle.crt > src/node_root_certs.h` 3. `rm ca-bundle.crt certdata.txt` fix nodejs#8679
Member
|
Sorry, but I think we should just automatically update it, since the file is automatically generated anyway. See: #8709 for details. |
indutny
added a commit
to indutny/node
that referenced
this pull request
Nov 11, 2014
NOTE: To reproduce/update this - run: 1. `perl tools/mk-ca-bundle.perl` 2. `node tools/rebuild-root-certs.js ca-bundle.crt > src/node_root_certs.h` 3. `rm ca-bundle.crt certdata.txt` fix nodejs#8679
Author
|
Agreed, very nice. |
bnoordhuis
added a commit
to bnoordhuis/node
that referenced
this pull request
Nov 14, 2014
Update tools/certdata.txt to [0] (last updated on 2014-11-14) and rebuild src/node_root_certs.h. Refs nodejs#8679 and nodejs#8709. [0] https://hg.mozilla.org/mozilla-central/raw-file/64206634959a/security/nss/lib/ckfw/builtins/certdata.txt
indutny
pushed a commit
that referenced
this pull request
Dec 4, 2014
Update tools/certdata.txt to [0] (last updated on 2014-11-14) and rebuild src/node_root_certs.h. Refs #8679 and #8709. [0] https://hg.mozilla.org/mozilla-central/raw-file/64206634959a/security/nss/lib/ckfw/builtins/certdata.txt
mscdex
pushed a commit
to mscdex/node
that referenced
this pull request
Dec 25, 2014
Update tools/certdata.txt to [0] (last updated on 2014-11-14) and rebuild src/node_root_certs.h. Refs nodejs#8679 and nodejs#8709. [0] https://hg.mozilla.org/mozilla-central/raw-file/64206634959a/security/nss/lib/ckfw/builtins/certdata.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...6 algorithm.
Global Sign has three relevant root certificates:
GlobalSign Root R1
GlobalSign Root R2
GlobalSign Root R3
Both R1 and R2 are present, but R3 is missing.
R3 is the more secure root certificate authority that uses SHA256 instead of the degrading SHA1. The root certificate list should be fixed to include all three Global Sign Root certificates.
See article about SHA1's degrading viability as a secure hash algorithm:
https://www.schneier.com/blog/archives/2005/02/cryptanalysis_o.html
For validation here is the source of the certificate: https://support.globalsign.com/customer/portal/articles/1426602-globalsign-root-certificates