This repository was archived by the owner on Apr 22, 2023. It is now read-only.
crypto: allow forcing SSLv2/v3 via secureProtocol#8575
Closed
indutny wants to merge 1 commit intonodejs:v0.10from
Closed
crypto: allow forcing SSLv2/v3 via secureProtocol#8575indutny wants to merge 1 commit intonodejs:v0.10from
indutny wants to merge 1 commit intonodejs:v0.10from
Conversation
Force-enable SSLv2/v3 when `secureProtocol` is explicitly set to `SSLv2_method` or `SSLv3_method`. see discussion at nodejs#8551
There was a problem hiding this comment.
This isn't 100% right, the secureProtocol should also handle the undefined case, but should happen below not when we're defining the default options, it should be set when flags is undefined and when secureProtocol isn't SSLv23...
|
Landed in a slightly different javascript implementation -- 1349b68 |
|
I presume the end-user gets some kind of flag to note the less-secure-than-desired connection in these rare cases? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force-enable SSLv2/v3 when
secureProtocolis explicitly setto
SSLv2_methodorSSLv3_method.see discussion at #8551