This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Add tls.start()#848
Closed
weaver wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
|
Hey Ben, |
Author
|
Sure thing, I'll write something up. |
|
@weaver did you have a chance to make a test? Could you update the pull request? Thanks! |
Author
|
This slipped my mind, apologies! I'll update the pull request today. |
|
is there a chance this could get expanded to tls.createSocket(options) on which you can later call connect(port, host, callback)? |
|
Sorry for the delay, this has been fixed in v0.7.0 (#2489). You can pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the pull request for
tls.start(); see mailing list thread here. Thanks!