This repository was archived by the owner on Apr 22, 2023. It is now read-only.
crypto: update root certificates#6489
Merged
bnoordhuis merged 4 commits intonodejs:masterfrom Nov 11, 2013
Merged
Conversation
Remove unneeded functionality and tweak the generated output so we can #include it in C++ source code.
This is a file from the NSS project containing root certificate data. It can be downloaded from: https://mxr.mozilla.org/mozilla/source/security/nss/lib/ckfw/builtins/certdata.txt?raw=1 Once downloaded, running `perl tools/mk-ca-bundle.pl` will update src/node_root_certs.h. Commit, rebuild and go.
Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl and update src/node_crypto.cc to make use of the new format. Fixes nodejs#6013.
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit bnoordhuis/node@d4c09f2 has the following error(s):
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
Member
Author
I know and that's not going to get fixed, Jenkins bot. It's a URL. |
|
I verified that this resolved the problem with the Go Daddy Class 2 certificate that was discussed on #6013. |
Member
Author
|
Cheers, thanks for testing. Landed in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the list of root certificates in src/node_root_certs.h with
tools/mk-ca-bundle.pl and update src/node_crypto.cc to make use of
the new format.
Fixes #6013.
Suggested reviewer: @indutny