This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Added a property to indicate generated message on AssertionError#6206
Closed
glenjamin wants to merge 1 commit intonodejs:masterfrom
Closed
Added a property to indicate generated message on AssertionError#6206glenjamin wants to merge 1 commit intonodejs:masterfrom
glenjamin wants to merge 1 commit intonodejs:masterfrom
Conversation
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit glenjamin/node@a2c9e11 has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
AssertionError.generatedMessage is now true when AssertionError.message was generated from expected and actual
Member
|
@tjfontaine I see you've been involved in #5836. Feel like reviewing this? |
ghost
assigned
|
Thanks merged in 66b8c3c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssertionError.generatedMessage indicates if .message was generated
As discussed in #5836