https: fix default port#5991
https: fix default port#5991koichik wants to merge 1 commit intonodejs:masterfrom koichik:fix-https-default-port
Conversation
https.get('https://github.com/') should use port 443, not 80.
There was a problem hiding this comment.
So lib/_http_agent.js doesn't export globalAgent? That looks like a buglet to me that could (and arguably should) be fixed by moving the declaration of globalAgent from lib/http.js to lib/_http_agent.js (and having lib/http.js re-export it). That would also remove the need to call require('http') below. Agree/disagree?
There was a problem hiding this comment.
I agree, _http_client.js shouldn't depend on http.js. However, actually, 40e9265 moved globalAgent from _http_agent.js to http.js. hmm...
There was a problem hiding this comment.
Probably an oversight, seeing that it broke lib/_http_client.js. I'm okay with undoing that, i.e. moving it back to lib/_http_agent.js again.
/cc @isaacs
There was a problem hiding this comment.
Yes, that looks like an oversight to me. Will fix momentarily, and then rebase @koichik's patch onto it.
|
Ack whoops, didn't realize it was in |
3 participants
https.get('https://github.com/')should use port 443, not 80.