This repository was archived by the owner on Apr 22, 2023. It is now read-only.
docs: Updates dgram doc with optional port for socket.bind()#5686
Closed
dcousens wants to merge 2 commits intonodejs:masterfrom
dcousens:patch-1
Closed
docs: Updates dgram doc with optional port for socket.bind()#5686dcousens wants to merge 2 commits intonodejs:masterfrom dcousens:patch-1
dcousens wants to merge 2 commits intonodejs:masterfrom
dcousens:patch-1
Conversation
|
Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion. Commit RommelVR/node@a2977963c40daa79b7a0e2e8675be9d8ce188e54 has the following error(s):
The following commiters were not found in the CLA:
You can fix all these things without opening another issue. Please see CONTRIBUTING.md for more information |
Member
There was a problem hiding this comment.
Long line, please wrap at 80 columns.
Member
There was a problem hiding this comment.
Also, the "does the right thing" comment elsewhere applies to the address, not the port.
Author
There was a problem hiding this comment.
Is what exists now suitable? (See latest commit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained several times throughout this document already:
and
I felt for an API lookup, it is a good idea to repeat this in
socket.binditself.