This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Add patch for stack overflow messages#4252
Closed
dizzyd wants to merge 1 commit intonodejs:v0.8from
dizzyd:v0.8.14-stackoverflowmsg
Closed
Add patch for stack overflow messages#4252dizzyd wants to merge 1 commit intonodejs:v0.8from dizzyd:v0.8.14-stackoverflowmsg
dizzyd wants to merge 1 commit intonodejs:v0.8from
dizzyd:v0.8.14-stackoverflowmsg
Conversation
|
Is it possible to upload this to chromium backported patch to chromium code review and ask the v8 guys to land it in v8 v3.11.10 ? |
Author
|
I have a dialog going with one of the V8 engineers -- I'll see what he thinks about backporting it to that version. |
Author
|
Nope -- the V8 team will not backport this as it's a new feature and they don't receive real-world crash data anymore for 3.11.x (because of it's age). This patch will land in 3.15, but not sure how prepared node is to make that leap. :) |
|
We have this in 0.10 already. Thanks! |
smanders
pushed a commit
to externpro-archive/node-v0.x-archive
that referenced
this pull request
Dec 17, 2015
Notable changes:
* buffer:
- Buffer.prototype.includes() has been added to keep parity
with TypedArrays. (Alexander Martin) nodejs#3567.
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) nodejs#3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) nodejs#4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) nodejs#4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) nodejs#4276.
PR-URL: nodejs/node#4281
Conflicts:
src/node_version.h
richardlau
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Jan 13, 2016
Notable changes:
* buffer:
- Buffer.prototype.includes() has been added to keep parity
with TypedArrays. (Alexander Martin) nodejs#3567.
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) nodejs#3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) nodejs#4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) nodejs#4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) nodejs#4276.
PR-URL: nodejs/node#4281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch for V8 originates from: http://codereview.chromium.org/11275186/
The original patch from that URL does not apply cleanly to the v0.8 version of V8, so I've resolved the conflicts by hand.