tls: do not hang without newSession handler#25739
tls: do not hang without newSession handler#25739indutny wants to merge 2 commits intonodejs:v0.12from
newSession handler#25739Conversation
When listening for client hello parser events (like OCSP requests), do not hang if `newSession` event handler is not present. Fix: nodejs#8660 Fix: nodejs#25735 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: node-forward/node#47
|
cc @joyent/node-collaborators |
There was a problem hiding this comment.
Can we use common.mustCall(function() {}, 0)?
|
Can we get some action on this - it's a pressing concern for us. |
|
@sam-github it is effectively a backport from io.js, except the new test case. @sam-github should I just land the PR by hand as we do in io.js? |
|
@sam-github simply adding a listener doesn't work since we use |
|
@indutny you've committed way more to joyent/node than I have! I don't think the procedure is changed much from when you were working all the time over here, but I don't recall from the onboarding, and can't find anything specific to how to land in https://nodejs.org/contribute/code_contributions/workflow.html |
|
Thanks @sam-github figured it out with @misterdjules |
When listening for client hello parser events (like OCSP requests), do not hang if `newSession` event handler is not present. Fix: #8660 Fix: #25735 Reviewed-By: Fedor Indutny <[email protected]> PR-URL: #25739
See: #25736 Reviewed-By: Fedor Indutny <[email protected]> PR-URL: #25739
Reviewed-By: Fedor Indutny <[email protected]> PR-URL: #25739
|
Looks like it landed in v0.12. |
When listening for client hello parser events (like OCSP requests), do not hang if `newSession` event handler is not present. Fix: nodejs#8660 Fix: nodejs#25735 Reviewed-By: Fedor Indutny <[email protected]> PR-URL: nodejs#25739
See: nodejs#25736 Reviewed-By: Fedor Indutny <[email protected]> PR-URL: nodejs#25739
Reviewed-By: Fedor Indutny <[email protected]> PR-URL: nodejs#25739
5 participants
When listening for client hello parser events (like OCSP requests), do
not hang if
newSessionevent handler is not present.