This repository was archived by the owner on Apr 22, 2023. It is now read-only.
test: Extend timeout due to failure on AIX#25138
Closed
mhdawson wants to merge 1 commit intonodejs:v0.12from
mhdawson:wrap-timeout-failure2
Closed
test: Extend timeout due to failure on AIX#25138mhdawson wants to merge 1 commit intonodejs:v0.12from mhdawson:wrap-timeout-failure2
mhdawson wants to merge 1 commit intonodejs:v0.12from
mhdawson:wrap-timeout-failure2
Conversation
The loopback on AIX is slower by default than on other platforms and we've seen a number of tests fail on AIX for this reason. This looks to be another instance. Changing the test to bind to the host ip instead of the loopback makes it pass reliably. This change extends the timeout so that it passes reliably on AIX even with the slower loopback behaviour modified: test/simple/test-tls-wrap-timeout.js
|
LGTM |
mhdawson
added a commit
that referenced
this pull request
May 6, 2015
The loopback on AIX is slower by default than on other platforms and we've seen a number of tests fail on AIX for this reason. This looks to be another instance. Changing the test to bind to the host ip instead of the loopback makes it pass reliably. This change extends the timeout so that it passes reliably on AIX even with the slower loopback behaviour modified: test/simple/test-tls-wrap-timeout.js Reviewed-By: coln Ihrig <[email protected]> PR-URL: #25138
Member
Author
|
Landed as fcbf226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loopback on AIX is slower by default than on other platforms
and we've seen a number of tests fail on AIX for this reason. This
looks to be another instance. Changing the test to bind to the
host ip instead of the loopback makes it pass reliably.
This change extends the timeout so that it passes reliably on AIX
even with the slower loopback behaviour