This repository was archived by the owner on Apr 22, 2023. It is now read-only.
correct example code#14002
Closed
AlexKVal wants to merge 1 commit intonodejs:masterfrom
AlexKVal:patch-1
Closed
Conversation
|
Thanks @AlexKVal for your contribution! The sample code describes the normal usage of However I agree that it's slightly confusing since the example is right after the sentence Maybe we could have the normal use case sample code before that sentence, and have a specific code sample for the write-after-end error after that sentence? What do you think? |
Author
|
Agree. I had written it without thinking some steps ahead. Something like this ?
|
|
@AlexKVal Right, something like: |
Author
|
I'm closing this PR because of #15517. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.