Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

test/simple/test-repl-tab-complete.js: tests get skipped silently #9006

@ackalker

Description

@ackalker

Building node from master on Arch Linux x86_64, I find that tests in test/simple/test-repl-tab-complete.js get skipped silently (no assertions thrown, no core dumps, etc.) after the following function call: https://github.com/joyent/node/blob/master/test/simple/test-repl-tab-complete.js#L152 .

Steps to reproduce / test:

console.log("before testMe.complete()");
testMe.complete('inner.o', function(error, data) {
  console.log("-> before assert.deepEqual()");
  assert.deepEqual(data, doesNotBreak);
  console.log("-> after assert.deepEqual()");
});
console.log("after testMe.complete()");
  • Run the test manually, so console messages don't get suppressed.

Actual output:

$ out/Release/node test/simple/test-repl-tab-complete.js
before testMe.complete()
-> before assert.deepEqual()
$

Assuming that the test should pass, this is the expected output:

$ out/Release/node test/simple/test-repl-tab-complete.js
before testMe.complete()
-> before assert.deepEqual()
-> after assert.deepEqual()
after testMe.complete()
$

It looks like this assert.deepEqual() causes execution to skip any further processing of the tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions