smalloc: check if obj has external data

vkurchatkin · trevnorris · commit f65a5cbcde51 · 2014-11-05T00:33:00.000-08:00
PR-URL: #8655 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
diff --git a/lib/smalloc.js b/lib/smalloc.js
@@ -86,6 +86,8 @@ function dispose(obj) {
     throw new TypeError('obj must be an Object');
   if (util.isBuffer(obj))
     throw new TypeError('obj cannot be a Buffer');
+  if (!smalloc.hasExternalData(obj))
+    throw new Error('obj has no external array data');
 
   smalloc.dispose(obj);
 }
diff --git a/test/simple/test-smalloc.js b/test/simple/test-smalloc.js
@@ -314,11 +314,15 @@ for (var i = 0; i < 5; i++)
 
 // only allow object to be passed to dispose
 assert.throws(function() {
-  alloc.dispose(null);
+  smalloc.dispose(null);
 });
 
 
 // can't dispose a Buffer
 assert.throws(function() {
-  alloc.dispose(new Buffer());
+  smalloc.dispose(new Buffer());
+});
+
+assert.throws(function() {
+  smalloc.dispose({});
 });

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,8 @@ function dispose(obj) {`
`86`	`86`	`throw new TypeError('obj must be an Object');`
`87`	`87`	`if (util.isBuffer(obj))`
`88`	`88`	`throw new TypeError('obj cannot be a Buffer');`
	`89`	`+ if (!smalloc.hasExternalData(obj))`
	`90`	`+ throw new Error('obj has no external array data');`
`89`	`91`
`90`	`92`	`smalloc.dispose(obj);`
`91`	`93`	`}`