Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

Commit d6249d0

Browse files
trevnorristrevnorris
committed
deps: update V8 to 3.28.71.19
The 3.28.73 update was technically unstable code. This reverts the code to the latest 3.28 stable release.
1 parent b3aa876 commit d6249d0

97 files changed

Lines changed: 3530 additions & 2212 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎deps/v8/.DEPS.git‎

Lines changed: 0 additions & 108 deletions
This file was deleted.

‎deps/v8/.clang-format‎

Lines changed: 0 additions & 4 deletions
This file was deleted.

‎deps/v8/.gitignore‎

Lines changed: 0 additions & 82 deletions
This file was deleted.

‎deps/v8/ChangeLog‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
2014-08-13: Version 3.28.73
2-
3-
Performance and stability improvements on all platforms.
4-
5-
61
2014-08-12: Version 3.28.71
72

83
ToNumber(Symbol) should throw TypeError (issue 3499).

‎deps/v8/build/features.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
'Release': {
116116
'variables': {
117117
'v8_enable_extra_checks%': 0,
118-
'v8_enable_handle_zapping%': 1,
118+
'v8_enable_handle_zapping%': 0,
119119
},
120120
'conditions': [
121121
['v8_enable_extra_checks==1', {

‎deps/v8/include/v8.h‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4186,17 +4186,6 @@ class V8_EXPORT Isolate {
41864186
*/
41874187
static Isolate* GetCurrent();
41884188

4189-
/**
4190-
* Custom callback used by embedders to help V8 determine if it should abort
4191-
* when it throws and no internal handler can catch the exception.
4192-
* If FLAG_abort_on_uncaught_exception is true, then V8 will abort if either:
4193-
* - no custom callback is set.
4194-
* - the custom callback set returns true.
4195-
* Otherwise it won't abort.
4196-
*/
4197-
typedef bool (*abort_on_uncaught_exception_t)();
4198-
void SetAbortOnUncaughtException(abort_on_uncaught_exception_t callback);
4199-
42004189
/**
42014190
* Methods below this point require holding a lock (using Locker) in
42024191
* a multi-threaded environment.

‎deps/v8/src/api.cc‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5543,6 +5543,11 @@ bool v8::String::CanMakeExternal() {
55435543
i::Handle<i::String> obj = Utils::OpenHandle(this);
55445544
i::Isolate* isolate = obj->GetIsolate();
55455545

5546+
// TODO(yangguo): Externalizing sliced/cons strings allocates.
5547+
// This rule can be removed when all code that can
5548+
// trigger an access check is handlified and therefore GC safe.
5549+
if (isolate->heap()->old_pointer_space()->Contains(*obj)) return false;
5550+
55465551
if (isolate->string_tracker()->IsFreshUnusedString(obj)) return false;
55475552
int size = obj->Size(); // Byte size of the original string.
55485553
if (size < i::ExternalString::kShortSize) return false;
@@ -6731,6 +6736,7 @@ void v8::Isolate::LowMemoryNotification() {
67316736
}
67326737
}
67336738

6739+
67346740
int v8::Isolate::ContextDisposedNotification() {
67356741
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
67366742
return isolate->heap()->NotifyContextDisposed();

‎deps/v8/src/array-iterator.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ function ExtendArrayPrototype() {
120120
%CheckIsBootstrapping();
121121

122122
InstallFunctions($Array.prototype, DONT_ENUM, $Array(
123+
// No 'values' since it breaks webcompat: http://crbug.com/409858
123124
'entries', ArrayEntries,
124-
'values', ArrayValues,
125125
'keys', ArrayKeys
126126
));
127127

‎deps/v8/src/array.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1480,7 +1480,6 @@ function SetUpArray() {
14801480
find: true,
14811481
findIndex: true,
14821482
keys: true,
1483-
values: true,
14841483
};
14851484
%AddNamedProperty($Array.prototype, symbolUnscopables, unscopables,
14861485
DONT_ENUM | READ_ONLY);

‎deps/v8/src/base/platform/platform-posix.cc‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -321,15 +321,11 @@ int OS::GetCurrentProcessId() {
321321

322322

323323
int OS::GetCurrentThreadId() {
324-
#if V8_OS_MACOSX
325-
return static_cast<int>(pthread_mach_thread_np(pthread_self()));
326-
#elif V8_OS_LINUX
324+
#if defined(ANDROID)
327325
return static_cast<int>(syscall(__NR_gettid));
328-
#elif V8_OS_ANDROID
329-
return static_cast<int>(gettid());
330326
#else
331-
return static_cast<int>(pthread_self());
332-
#endif
327+
return static_cast<int>(syscall(SYS_gettid));
328+
#endif // defined(ANDROID)
333329
}
334330

335331

@@ -608,8 +604,9 @@ void Thread::Join() {
608604

609605

610606
void Thread::YieldCPU() {
611-
const timespec delay = { 0, 1 };
612-
nanosleep(&delay, NULL);
607+
int result = sched_yield();
608+
DCHECK_EQ(0, result);
609+
USE(result);
613610
}
614611

615612

0 commit comments

Comments
 (0)