Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

feat: auto-resume on start breakpoint#80

Merged
hybrist merged 2 commits intonodejs:masterfrom
dolsem:master
Apr 20, 2020
Merged

feat: auto-resume on start breakpoint#80
hybrist merged 2 commits intonodejs:masterfrom
dolsem:master

Conversation

@dolsem
Copy link
Contributor

@dolsem dolsem commented Feb 9, 2020

Fixes #65.

This PR is to automatically resume execution after debugger is paused on start, in case NODE_INSPECT_RESUME_ON_START environment variable is set to 1.

Copy link
Collaborator

@hybrist hybrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! The overall approach looks good but I think I'd like to keep _inspect.js more minimal.

@dolsem
Copy link
Contributor Author

dolsem commented Apr 20, 2020

@jkrems I finally got to updating this. Hopefully should be all set now.

Copy link
Collaborator

@hybrist hybrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for working on this.

@hybrist hybrist merged commit fec399b into nodejs:master Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request for CLI debugger: Disable "break on start"

2 participants