This repository was archived by the owner on Feb 1, 2022. It is now read-only.
fix: Avoid using process.binding()#76
Merged
hybrist merged 1 commit intonodejs:masterfrom Jan 22, 2020
Merged
Conversation
hybrist
approved these changes
Jan 21, 2020
This is deprecated and emits a warning with `--pending-deprecation`. I’m afraid I’m not familiar enough with this code to provide a test, unfortunately.
hybrist
force-pushed
the
no-process-binding
branch
from
145fccf to
fbec9db
Compare
Collaborator
|
Rebased to get the CI checks in here. Thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is deprecated and emits a warning with
--pending-deprecation.I’m afraid I’m not familiar enough with this code to provide a test,
unfortunately.