Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-inspect
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.11.2
Choose a base ref
...
head repository: nodejs/node-inspect
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.11.3
Choose a head ref
  • 6 commits
  • 10 files changed
  • 4 contributors

Commits on Jan 24, 2018

  1. docs: Add missing oc in protocol

    @kevinsawicki
    kevinsawicki authored and Jan Krems committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    93caa0f View commit details
    Browse the repository at this point in the history

  2. fix: Make --inspect-port=0 work 

    Selecting port zero makes the inspector bind to a random port.

The inspector prints the URL it listens on to stderr.  Parse the
output from the child process to find the port number.

This commit coincidentally also makes `node inspect --port=0 x.js`
work and a regression test to that effect has been added.

Note that connecting to an existing process that listens on a
non-standard port with `node inspect -p <pid>` does not work
because then we never see the output from the inspector.

Fixes: nodejs/node#16469
    @bnoordhuis
    bnoordhuis authored and Jan Krems committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    2d87cbe View commit details
    Browse the repository at this point in the history

  3. chore: Bump tap to 10.7

    Jan Krems committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    ebfd02e View commit details
    Browse the repository at this point in the history

  4. test: Use useful break location

    Jan Krems committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    c07adb1 View commit details
    Browse the repository at this point in the history

  5. fix: Fix takeHeapSnapshot() truncation bug 

    Fix a logic bug in `takeHeapSnapshot()` where it interpreted the item
count as the byte count, resulting in truncated snapshots.

This change hinges on the observation that the completion callback
always comes after any and all `'addHeapSnapshotChunk'` events.

I'm 95% sure after digging into the V8 inspector and its integration
with Node.js that the assumption above is correct.

If it turns out I'm mistaken, then we will most likely treat that as
a bug in Node.js, not node-inspect.

Fixes: #56
    @bnoordhuis
    bnoordhuis authored and Jan Krems committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    94f0bf9 View commit details
    Browse the repository at this point in the history

  6. v1.11.3

    @i-tier-bot
    i-tier-bot committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    3c9073f View commit details
    Browse the repository at this point in the history
Loading