Update minimatch#961
Closed
delphiactual wants to merge 1 commit intonodejs:masterfrom
delphiactual:master
Closed
Conversation
Member
|
thanks @delphiactual, do you have any context to share here, what might have changed and/or broken between 1 & 3 that we might need to look out for? |
Contributor
Author
|
Latest commit which brought him up to 3.0.2 fixes a DoS that can occur in older versions. Whether anything else changed between 1 & 3 I have no idea. Maybe @isaacs can give you more info. |
Member
|
Yeah, I've just had a cruise through some of the changes and it doesn't seem to be anything major other than style, removal of internal caching and other bits and pieces that I can't see impacting on our minimal usage: This lgtm. Anyone else? |
Member
|
merged, thanks @delphiactual |
This was referenced Jun 27, 2016
rvagg
pushed a commit
that referenced
this pull request
Jun 28, 2016
PR-URL: #961 Reviewed-By: Rod Vagg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.