Move VC++ Build Tools to Build Tools landing page#953
Closed
AndrewPardoe wants to merge 1 commit intonodejs:masterfrom
Closed
Move VC++ Build Tools to Build Tools landing page#953AndrewPardoe wants to merge 1 commit intonodejs:masterfrom
AndrewPardoe wants to merge 1 commit intonodejs:masterfrom
Conversation
Author
|
I deleted an 's' at the end of the URL. It's "tools". Sorry, I'll fix that in an hour or so. Edit: My change seems to be correct. Did you copy-paste the URL incorrectly, @bnoordhuis? You can also just click the URL on my fork: https://github.com/AndrewPardoe/node-gyp |
Contributor
|
The new URL seems correct. LGTM |
bnoordhuis
pushed a commit
that referenced
this pull request
Jun 16, 2016
PR-URL: #953 Reviewed-By: Alexis Campailla <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Member
|
Landed in af35b2a, thanks Andrew. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've (finally!) created an actual landing page for the VC++ Build Tools. We'd like your readme to refer people to the landing page rather than directly to the download. This change moves the target of that link.