Upgrade to [email protected].#943
Merged
bnoordhuis merged 1 commit intonodejs:masterfrom May 31, 2016
bnoordhuis:glob
Merged
Conversation
Contributor
|
lgtm if it works I suppose. Tests pass here. |
Member
|
Yeah, LGTM. I can't find info on what broken between While you're in there, you could remove the |
Matches what npm v2.15.5 and npm v3.8.6 use. Fixes: #941 PR-URL: #943 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Member
Author
|
Landed in ac29d23 with the usage in lib/configure.js removed. Thanks for the reviews. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches what npm v2.15.5 and npm v3.8.6 use.
Fixes: #941
R=@rvagg?