updating readme for Windows 10 support fixes #679#766
updating readme for Windows 10 support fixes #679#766jasonwilliams wants to merge 1 commit intonodejs:masterfrom jasonwilliams:updatingWindows10Doc
Conversation
|
@TooTallNate can you or another maintainer take a look at this. I didn't see this requiring any code updates. Just taking the steps necessary to get the environment correct. Most notably I think having the latest version of NPM makes the biggest difference! |
|
pings @TooTallNate |
There was a problem hiding this comment.
Maybe write this as:
`npm install --msvs_version=2015` (`--msvs_version` is not needed if GYP_MSVS_VERSION is set)
It renders more nicely on GH that way.
|
LGTM with a suggestion. Can you squash the commits and write up a nice commit log? Please capitalize and punctuate sentences. Thanks. |
|
@bnoordhuis you know how i can squash the commits after doing a PR? I've not done that before |
|
@Jayflux Do If you google around, some people will tell you to |
|
Oh, and please post a comment when you're done. GH doesn't send notifications when you add or modify commits. |
|
hmm @bnoordhuis not sure that did it, was i supposed to do something in the rebase console? I just closed |
|
Yes, you should be doing that from the command line. |
|
@bnoordhuis yep rebase opened up vim I think |
|
@TooTallNate I think the changes have been reflected in this PR for some reason |
PR-URL: #766 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks Jason, landed in a8d441a. |
3 participants
Updating the documentation for users on Windows 10
Fixes #679