Fix test/test-options when run through npm test.#755
Merged
bnoordhuis merged 1 commit intonodejs:masterfrom Nov 19, 2015
bnoordhuis:fix-options-test
Merged
Fix test/test-options when run through npm test.#755bnoordhuis merged 1 commit intonodejs:masterfrom bnoordhuis:fix-options-test
npm test.#755bnoordhuis merged 1 commit intonodejs:masterfrom
bnoordhuis:fix-options-test
Conversation
Member
Author
|
Or R=@TooTallNate? |
Member
Author
|
@mhdawson Can you return the favor and review this PR? |
Member
|
lgtm @bnoordhuis, sorry for the delay, this is a good change |
`npm test` dumps a ton of npm_config_* variables in the environment. Remove those before starting the actual test. PR-URL: #755 Reviewed-By: Rod Vagg <[email protected]>
Koroffin
pushed a commit
to Koroffin/node-gyp
that referenced
this pull request
Sep 8, 2025
fix: ensure proper cleanup of console process on shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm testdumps a ton of npm_config_* variables in the environment.Remove those before starting the actual test.
R=@rvagg?