normalise versions for target == this comparison#716
Closed
rvagg wants to merge 1 commit intonodejs:masterfrom
rvagg:normalise-version-comparison
Closed
normalise versions for target == this comparison#716rvagg wants to merge 1 commit intonodejs:masterfrom rvagg:normalise-version-comparison
rvagg wants to merge 1 commit intonodejs:masterfrom
rvagg:normalise-version-comparison
Conversation
10 tasks
Member
Author
|
thanks @targos, fixed |
rvagg
added a commit
that referenced
this pull request
Sep 8, 2015
Member
Author
|
landing to get this into 4.0.0-rc.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the
node-gyp rebuildcase, everything is calculated fine forconfigurebut then when it gets toinstallit's passing in anargv[0]with the version number and thevis stripped from that version but we are comparing withprocess.versionwhich has avso the naive comparison says it's not the same version and therefore we are not targetting the "default".The solution here is to simply normalise
process.versionand match it to the already normalised target version so the comparison is fair.Reported here for 4.0.0-rc.4