configure: don't clobber existing $PYTHONPATH#509
Merged
TooTallNate merged 1 commit intonodejs:masterfrom May 24, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
Funnily enough, this would be a good use-case for my path-array module.
Contributor
Author
There was a problem hiding this comment.
Sounds good, if you don't mind the extra dependency just for these couple of lines - I didn't know about that module. Want me to redo the PR, or are you happy to do that since you're presumably pretty familiar with it?
TooTallNate
added a commit
that referenced
this pull request
May 24, 2015
configure: don't clobber existing $PYTHONPATH
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My
nodeexecutable happens to be a wrapper created by 0install, implemented in python. It relies on some library code being available on$PYTHONPATH. Which means it can't run whennpm-gypoverwrites$PYTHONPATHto include only the bundledgyp/pylibdir.This commit achieves the same effect as the existing code (giving the bundled
gypmodule priority), but without clobbering an existing$PYTHONPATHvalue.