feat: Support for Visual Studio 2026 (18.x) to enable node-gyp to work with the latest Visual Studio preview and release versions.#3240
Conversation
feat: Add support for Visual Studio 2026 (18.x) - Add versionMajor 18 mapping to versionYear 2026 - Update toolset to v145 for VS2026 (confirmed from MS docs) - Support both Insiders (18\Insiders) and Release (2026\Community) installation paths - Add comprehensive test coverage for both VS2026 variants - Maintain backward compatibility with all existing VS versions This enables node-gyp to work with Visual Studio 2026 Preview/Insiders and future 18.x releases.
| } else if (versionYear === 2022) { | ||
| return 'v143' | ||
| } else if (versionYear === 2026) { | ||
| return 'v145' |
There was a problem hiding this comment.
It seems like this version has not been updated in the doc yet: https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#version-macros
There was a problem hiding this comment.
It seems like this version has not been updated in the doc yet: https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170#version-macros
Clearly, Microsoft's development team is far behind in terms of documentation update speed.
However, I can assure you that VS2026 uses version 145 and has passed rigorous unit and compilation tests.
My personal product has been successfully compiled and released using this PR. ;)
Checklist
npm install && npm run lint && npm testpassesDescription of change
Add support for Visual Studio 2026 (18.x) to enable node-gyp to work with the latest Visual Studio preview and release versions.
Changes made:
getVersionInfo()functionC:\Program Files\Microsoft Visual Studio\18\InsidersC:\Program Files\Microsoft Visual Studio\2026\CommunityTechnical Details:
lib/find-visualstudio.jswith new version mappingsVS_2026_Insiders_workload.txtandVS_2026_Community_workload.txtThis change enables developers using Visual Studio 2026 to compile native Node.js addons without manual configuration.