chore: skip test when python version is unsupported on platform#2772
chore: skip test when python version is unsupported on platform#2772lukekarrys wants to merge 1 commit intonodejs:mainfrom
Conversation
There was a problem hiding this comment.
Python 3.6 is not supported anywhere... https://devguide.python.org/versions
My vote would be to drop Python 3.6 and not make the changes in this PR. Allowing failure and then testing for success sounds dicey and it would be easy to have logic errors that hide important failures.
The other alternative would be to test on Ubuntu 20-04 which still supports Py36.
Another alternative would be to strategy.matrix.exclude Py36 on Ubuntu.
|
TIL about But if 3.6 is no longer supported than I agree the best idea would be to drop it from the test matrix. |
|
Closing in favor of #2774 |
2 participants
Checklist
npm install && npm testpassesDescription of change
[email protected]is no longer supported onubuntu-latest(which is now22.04). See this recent workflow run to see the failure that occurs when the matrix tries to test that combination.This change makes CI skip all subsequent steps when the
setup-pythonstep fails.One downside to this is that the GitHub UI will still show ✅ for the workflow run instead of indicating that it was skipped.
Alternative options
Instead of this,
3.6could be dropped from the CI matrix, but I don't know enough about python usage to have an opinion on if that is a good idea.