Skip to content

feat: remove support for VS2015 in Node.js >=19#2746

Merged
gengjiawen merged 1 commit intonodejs:mainfrom
targos:bye-bye-vs2015
Oct 8, 2022
Merged

feat: remove support for VS2015 in Node.js >=19#2746
gengjiawen merged 1 commit intonodejs:mainfrom
targos:bye-bye-vs2015

Conversation

@targos
Copy link
Copy Markdown
Member

@targos targos commented Oct 7, 2022

@targos
Copy link
Copy Markdown
Member Author

targos commented Oct 7, 2022

/cc @nodejs/build @nodejs/npm @nodejs/releasers

We will need to coordinate an npm release with this change, its inclusion in v19.0.0, and adaptations to the Node.js CI.

@targos
Copy link
Copy Markdown
Member Author

targos commented Oct 7, 2022

I think this is something we should do regardless of issues with V8, to prepare users for Node.js 20. Visual Studio 2015 will be out of support on Oct 14, 2025, before the 20.x EoL.

@targos targos mentioned this pull request Oct 7, 2022
Closed
richardlau
richardlau approved these changes Oct 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I wonder if the commit message should mark this as a breaking change (we're using conventional commits for release-please).

@targos
Copy link
Copy Markdown
Member Author

targos commented Oct 7, 2022

I thought about it but since it only applies to an unreleased version of node, I thought it could not really break anyone

@targos
Copy link
Copy Markdown
Member Author

targos commented Oct 7, 2022

But feel free to land as breaking, I have no strong opinion on that

@richardlau
Copy link
Copy Markdown
Member

richardlau commented Oct 7, 2022

Ah good point about it referring to an unreleased version. I'm okay with it landing just as a feat (i.e. Node.js 19 support).

@gengjiawen gengjiawen merged commit 131d1a4 into nodejs:main Oct 8, 2022
@targos targos deleted the bye-bye-vs2015 branch October 8, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@sxa sxa sxa approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

+1 more reviewer

@Trott Trott Trott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@targos @richardlau @Trott @gengjiawen @sxa @RafaelGSS