docs: rephrase explanation of which node-gyp is used by npm#2587
Merged
rvagg merged 4 commits intonodejs:masterfrom Jan 7, 2022
Merged
docs: rephrase explanation of which node-gyp is used by npm#2587rvagg merged 4 commits intonodejs:masterfrom
rvagg merged 4 commits intonodejs:masterfrom
Conversation
rvagg
reviewed
Jan 7, 2022
rvagg
reviewed
Jan 7, 2022
rvagg
reviewed
Jan 7, 2022
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: Rod Vagg <[email protected]>
Contributor
Author
|
@rvagg thank you for review. Your changes are applyed |
rvagg
approved these changes
Jan 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Previous explanation went too deep regarding details about files hierarchy of
npm. This info may mislead windows users since in windowsnpmis located in other place than globalnode_modules.Also some minor changes like highlighting keywords and using direct names instead of pronouns