Log dist-url.#1170
Merged
bnoordhuis merged 1 commit intonodejs:masterfrom May 17, 2017
bnoordhuis:log-dist-url
Merged
Conversation
Contributor
|
seems like a good idea |
Member
Author
|
@Fishrock123 Can I take your comment as a LGTM? |
refack
approved these changes
May 15, 2017
The default download URL can be overridden by `--dist-url` or one of the `*_MIRROR` environment variables. Log the URL to ease troubleshooting. Fixes: #1169 PR-URL: #1170 Reviewed-By: Refael Ackermann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default download URL can be overridden by
--dist-urlor one of the*_MIRRORenvironment variables. Log the URL to ease troubleshooting.Fixes: #1169
CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/8/