test: fix test/test-configure-python on AIX#1131
test: fix test/test-configure-python on AIX#1131richardlau wants to merge 1 commit intonodejs:masterfrom
Conversation
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Would it be useful to add AIX to node-gyp's CI?
I think so. The code to search for node.exp is AIX specific, so won't be executed on any other platform. This test hasn't worked on AIX since it landed in October last year. I've proposed adding node-gyp to CITGM's default lookup.json (nodejs/citgm#370) which should give platform coverage when Node.js does new releases or tests significant PRs, but it would be much faster to catch these sort of things on node-gyp's CI runs if possible. cc @nodejs/platform-aix |
|
+1 to adding AIX to node-gyp's CI. I can take a look at doing that. |
|
@bnoordhuis can this land to unblock nodejs/citgm#370? |
|
Sure, go ahead and land it. Or is your question if I want to land it? |
|
@richardlau should these be squashed? Let me know and I'll land. |
On AIX, lib/configure.js attempts to locate node.exp via calls to fs.openSync() and fs.closeSync(). Add these functions to the mocked `graceful-fs` object in test/test-configure-python.js.
|
@gibfahn Rebased and squashed. |
|
EDIT: 4 test failures on 0.10.48 Ubuntu, can reproduce locally, seems to be broken since e3778d9 (Fixed in #1172). not ok 123 (unnamed assert)
---
operator: ok
expected: true
actual: false
at: Object.f.stat (/home/iojs/build/workspace/nodegyp-test-commit/nodes/ubuntu1604-64/test/test-find-python.js:291:7)
...
not ok 124 (unnamed assert)
---
operator: ok
expected: true
actual: false
at: Object.f.execFile (/home/iojs/build/workspace/nodegyp-test-commit/nodes/ubuntu1604-64/test/test-find-python.js:283:9)
...
ok 125 (unnamed assert)
not ok 126 (unnamed assert)
---
operator: ok
expected: true
actual: false
at: Object.done [as callback] (/home/iojs/build/workspace/nodegyp-test-commit/nodes/ubuntu1604-64/test/test-find-python.js:297:7)
...
# find python - no python, no python launcher, bad guess
ok 127 should be equal
ok 128 should be equal
not ok 129 (unnamed assert)
---
operator: ok
expected: true
actual: false
at: Object.f.stat (/home/iojs/build/workspace/nodegyp-test-commit/nodes/ubuntu1604-64/test/test-find-python.js:317:7)
... |
On AIX, lib/configure.js attempts to locate node.exp via calls to fs.openSync() and fs.closeSync(). Add these functions to the mocked `graceful-fs` object in test/test-configure-python.js. PR-URL: #1131 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in a83a380 |
6 participants
nodejs/citgm#370 (comment), test/test-configure-python is failing on AIX:
On AIX,
lib/configure.jsattempts to locate node.exp via calls to fs.openSync() and fs.closeSync(). Add these functions to the mockedgraceful-fsobject in test/test-configure-python.js.