Update link of gyp as Google code is shutting down#1061
Update link of gyp as Google code is shutting down#1061PeterDaveHello wants to merge 2 commits intonodejs:masterfrom PeterDaveHello:patch-1
Conversation
|
Would https://chromium.googlesource.com/external/gyp or https://gyp.gsrc.io/ be a better starting point for someone who doesn't know what gyp is? |
|
Oh cool, would you like me to update it? |
|
@PeterDaveHello Yes, sounds good to me. I guess you should use https://gyp.gsrc.io as that seems to be the homepage. |
|
@gibfahn thanks, if you don't mind, I just directly updated and committed on GitHub, I think you can squash them directly on GitHub, too, if you don't like it, I can clone and squash them locally or just send a new one, thanks. |
|
@PeterDaveHello looks fine to me. This needs a |
PR-URL: #1061 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
|
Thanks Peter, landed in ff9a6fa. |
3 participants
No description provided.