-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Description
Short summary: The content of this docs page from before this PR had steps that work in npm 7. Please host/restore the old content of this docs page somewhere. Furthermore, this PR caused the title/filename to not match the content. Please make it so the titles/filenames match the content.
Also: The title and filename of this do not match the content anymore, as of this PR. This advice is more about "Having npm use an independent copy of node-gyp instead of its bundled copy".
The title ("Updating the npm-bundled version of node-gyp") matches the previous content.
I would request that the previous content of this file be hosted somewhere in the docs... Preferably under this filename, to make the edit history follow-able. (In other words, please consider restoring the previous content of this file, and moving the new content to another file.)
I would humbly suggest to move the updated content to a new file, under an appropriate filename and title, with the understanding that it applies ONLY to npm 6 and lower, and saying so somewhere in this file, so users don't get surprised when it doesn't work in npm 7 or higher.
The method described as of this PR is a more durable, maybe less hacky fix for npm 6 users. So I do like this method. It's just a minor disappointment it doesn't work on newer npm right now.
Originally posted by @DeeDeeG in #2448 (comment)