Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v11.3.0
Choose a base ref
...
head repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v11.4.0
Choose a head ref
  • 6 commits
  • 10 files changed
  • 5 contributors

Commits on Aug 13, 2025

  1. build(deps): bump actions/checkout from 4 to 5 (#3193)

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-version: '5'
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 13, 2025
    Configuration menu
    Copy the full SHA
    27f5505 View commit details
    Browse the repository at this point in the history
  2. Lint Python: Ignore ruff rule PLC0415 (#3195)

    https://docs.astral.sh/ruff/rules/import-outside-top-level
    
    There are several valid reasons for conditionally importing Python modules, especially for OS-specific code, so let's intentionally ignore this rule.
    
    % `ruff check --select=PLC0415`
    ```
    Error: gyp/pylib/gyp/MSVSVersion.py:222:5: PLC0415 `import` should be at the top-level of a file
    Error: gyp/pylib/gyp/__init__.py:492:9: PLC0415 `import` should be at the top-level of a file
    Error: gyp/pylib/gyp/generator/make.py:81:9: PLC0415 `import` should be at the top-level of a file
    Error: gyp/pylib/gyp/generator/ninja.py:1998:9: PLC0415 `import` should be at the top-level of a file
    Error: gyp/pylib/gyp/generator/ninja.py:2021:9: PLC0415 `import` should be at the top-level of a file
    Error: gyp/pylib/gyp/generator/ninja.py:2091:9: PLC0415 `import` should be at the top-level of a file
    Error: gyp/pylib/gyp/mac_tool.py:145:9: PLC0415 `import` should be at the top-level of a file
    Error: gyp/test_gyp.py:151:9: PLC0415 `import` should be at the top-level of a file
    Error: gyp/test_gyp.py:157:9: PLC0415 `import` should be at the top-level of a file
    ```
    cclauss authored Aug 13, 2025
    Configuration menu
    Copy the full SHA
    71a910e View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2025

  1. Configuration menu
    Copy the full SHA
    0773615 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2025

  1. feat: support reading config from package.json (#3196)

    `npm@11` has deprecated setting arbitrary config values (npm/cli#8153), which was the previously recommended place for users to set node-gyp related config. The new recommendation from npm is to use the `config` object in package.json for this (npm/cli#8153 (comment)). I think it makes sense to follow npm's recommendation here.
    
    When a user sets a value in `package.json#config` it will be set in the environment by npm with the prefix `npm_package_config_<KEY>`.
    
    I think it makes sense to allow prescribe that they keys be prefixed with `node_gyp_`. So as an example:
    
    **package.json**
    ```json
    {
      "config": {
        "node_gyp_devdir": "/tmp/.gyp"
      }
    }
    ```
    
    Then in `node-gyp` we can read the env var `npm_package_config_node_gyp_devdir`. If a user wants to set a global value, they can set that env var on their system.
    
    Fixes #3156
    lukekarrys authored Aug 19, 2025
    Configuration menu
    Copy the full SHA
    1822dff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5538e6c View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2025

  1. chore(main): release 11.4.0

    nodejs-github-bot authored and lukekarrys committed Aug 20, 2025
    Configuration menu
    Copy the full SHA
    af41747 View commit details
    Browse the repository at this point in the history
Loading