-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v11.3.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v11.4.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 10 files changed
- 5 contributors
Commits on Aug 13, 2025
-
build(deps): bump actions/checkout from 4 to 5 (#3193)
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 27f5505 - Browse repository at this point
Copy the full SHA 27f5505View commit details -
Lint Python: Ignore ruff rule PLC0415 (#3195)
https://docs.astral.sh/ruff/rules/import-outside-top-level There are several valid reasons for conditionally importing Python modules, especially for OS-specific code, so let's intentionally ignore this rule. % `ruff check --select=PLC0415` ``` Error: gyp/pylib/gyp/MSVSVersion.py:222:5: PLC0415 `import` should be at the top-level of a file Error: gyp/pylib/gyp/__init__.py:492:9: PLC0415 `import` should be at the top-level of a file Error: gyp/pylib/gyp/generator/make.py:81:9: PLC0415 `import` should be at the top-level of a file Error: gyp/pylib/gyp/generator/ninja.py:1998:9: PLC0415 `import` should be at the top-level of a file Error: gyp/pylib/gyp/generator/ninja.py:2021:9: PLC0415 `import` should be at the top-level of a file Error: gyp/pylib/gyp/generator/ninja.py:2091:9: PLC0415 `import` should be at the top-level of a file Error: gyp/pylib/gyp/mac_tool.py:145:9: PLC0415 `import` should be at the top-level of a file Error: gyp/test_gyp.py:151:9: PLC0415 `import` should be at the top-level of a file Error: gyp/test_gyp.py:157:9: PLC0415 `import` should be at the top-level of a file ```
Configuration menu - View commit details
-
Copy full SHA for 71a910e - Browse repository at this point
Copy the full SHA 71a910eView commit details
Commits on Aug 18, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 0773615 - Browse repository at this point
Copy the full SHA 0773615View commit details
Commits on Aug 19, 2025
-
feat: support reading config from package.json (#3196)
`npm@11` has deprecated setting arbitrary config values (npm/cli#8153), which was the previously recommended place for users to set node-gyp related config. The new recommendation from npm is to use the `config` object in package.json for this (npm/cli#8153 (comment)). I think it makes sense to follow npm's recommendation here. When a user sets a value in `package.json#config` it will be set in the environment by npm with the prefix `npm_package_config_<KEY>`. I think it makes sense to allow prescribe that they keys be prefixed with `node_gyp_`. So as an example: **package.json** ```json { "config": { "node_gyp_devdir": "/tmp/.gyp" } } ``` Then in `node-gyp` we can read the env var `npm_package_config_node_gyp_devdir`. If a user wants to set a global value, they can set that env var on their system. Fixes #3156
Configuration menu - View commit details
-
Copy full SHA for 1822dff - Browse repository at this point
Copy the full SHA 1822dffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5538e6c - Browse repository at this point
Copy the full SHA 5538e6cView commit details
Commits on Aug 20, 2025
-
Configuration menu - View commit details
-
Copy full SHA for af41747 - Browse repository at this point
Copy the full SHA af41747View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v11.3.0...v11.4.0