Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 656117c
Choose a base ref
...
head repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bb92c76
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 9, 2019

  1. test: increase tap timeout 

    test-addon.js includes compiling code, making the default 30 second
timeout not suitable. This increases the timeout for all platforms,
which is a potential problem everywhere, fixing the timeout that
happens on Windows.

Fixes: #1801
PR-URL: #1812
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
    @joaocgreis
    joaocgreis committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    7fd9240 View commit details
    Browse the repository at this point in the history

  2. test: add Node.js 6 on Windows to Travis CI 

    Test the oldest supported Node version on Windows.

PR-URL: #1812
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
    @joaocgreis
    joaocgreis committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    bb92c76 View commit details
    Browse the repository at this point in the history
Loading