Conversation
targos
commented
Mar 6, 2024
Comment on lines
-33
to
-34
| strategy: | ||
| fail-fast: false |
Member
Author
There was a problem hiding this comment.
This was wrong. Fail-fast is setup inside the pkgjs action and is false by default: https://github.com/pkgjs/action/blob/main/docs/USAGE.md#strategy-fail-fast
targos
commented
Mar 6, 2024
| fail-fast: false | ||
| uses: codecov/codecov-action@v4 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
Member
Author
There was a problem hiding this comment.
Looks like secrets are not allowed here: https://github.com/nodejs/node-core-utils/actions/runs/8170900413
I'll remove the codecov update from this PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 37 37
Lines 4200 4200
=======================================
Hits 3485 3485
Misses 715 715 ☔ View full report in Codecov by Sentry. |
richardlau
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.