Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Sync to nodejs/master (2016-04-04) #52

Merged
jianchun merged 78 commits into from
Apr 6, 2016
Merged

Sync to nodejs/master (2016-04-04) #52

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
de92a66
test: move dns test to test/internet
bnoordhuis Mar 25, 2016
c169ac6
querystring: don't stringify bad surrogate pair
mscdex Mar 23, 2016
8b2e437
test: fix flaky test-net-socket-timeout
mscdex Mar 24, 2016
41feaa8
crypto: improve error messages
thefourtheye Sep 28, 2015
1213535
doc: fix doc for Buffer.readInt32LE()
ghaiklor Mar 24, 2016
a6b9b55
child_process: refactor self=this in socket_list
benjamingr Mar 23, 2016
a15906c
net: refactor self=this to arrow functions
benjamingr Mar 23, 2016
26a4a4b
build: add missing `openssl_fips%` to common.gypi
indutny Mar 27, 2016
afd821a
buffer: faster case for create buffer from empty string
JacksonTian Dec 18, 2015
293fd04
buffer: make byteLength work with ArrayBuffer & DataView
JacksonTian Feb 16, 2016
089c6a4
http: speed up checkIsHttpToken
JacksonTian Jan 21, 2016
4bc1ccc
dgram: pass null as error on successful send()
cjihrig Mar 28, 2016
41f333e
src,http_parser: remove KickNextTick call
trevnorris Mar 11, 2016
2dadd89
src: reword command and add ternary
trevnorris Mar 23, 2016
f9938b6
async_wrap: setupHooks now accepts object
trevnorris Feb 22, 2016
20337ad
async_wrap: notify post if intercepted exception
trevnorris Feb 23, 2016
a17200b
async_wrap: don't abort on callback exception
trevnorris Mar 14, 2016
9fa25c8
timers: fixing API refs to use safe internal refs
getify Aug 22, 2015
f0367d0
test: confirm globals not used internally
Trott Mar 24, 2016
b1c0587
test: exclude new fs watch test for AIX
mhdawson Mar 28, 2016
c7138e9
win,build: build and test add-ons on test-ci
Mar 24, 2016
89abe86
Revert "stream: emit 'pause' on nextTick"
evanlucas Mar 29, 2016
b6475b9
Revert "tty: don't read from console stream upon creation"
evanlucas Mar 29, 2016
ccd8188
etw,build: always generate .rc and .h files
joaocgreis Mar 11, 2016
d38503a
module: prioritize current dir for local lookups
phillipj Mar 13, 2016
652782d
test: update test-repl-require for local paths
Mar 13, 2016
82fdaae
test: remove the use of curl in the test suite
santigimeno Mar 16, 2016
a4c4a85
build: enable compilation for linuxOne
mhdawson Mar 28, 2016
761787b
test: add test for piping large input from stdin
addaleax Mar 29, 2016
05b3a0b
tools: fix json doc generation
firedfox Mar 29, 2016
ef6c4c6
test: fix flaky test-repl
mscdex Mar 25, 2016
bb28770
governance: remove target size for CTC
Trott Mar 23, 2016
4039ef1
doc: remove redundant parameter comments from fs
firedfox Mar 30, 2016
ea47cc4
test: mitigate flaky test-https-agent
Trott Mar 28, 2016
21d66d6
lib: remove bootstrap global context indirection
Fishrock123 Mar 23, 2016
33c27f8
test: add known_issues test for GH-2148
Trott Mar 27, 2016
54a5287
zlib: fix gzip member head/buffer boundary issue
addaleax Mar 24, 2016
1845c4f
etw: add event messages
joaocgreis Mar 21, 2016
d6c9f64
test: stdin is not always a net.Socket
Fishrock123 Mar 28, 2016
cf94929
assert: Check typed array view type in deepEqual
addaleax Mar 26, 2016
854f758
test: fix offending max-len linter error
thefourtheye Mar 31, 2016
0551021
2016-03-31, Version v4.4.2 'Argon' (LTS)
Mar 30, 2016
a20c700
test: ensure _handle property existence
Trott Mar 26, 2016
f1fc698
tools: remove obsolete lint config file
Trott Mar 30, 2016
64c87e2
2016-03-31 Version 5.10.0 (Stable) Release
evanlucas Mar 31, 2016
4882ec4
2016-03-31 Version 0.12.13 (LTS) Release
rvagg Mar 31, 2016
5fc6938
2016-03-31 Version 0.10.44 (Maintenance) Release
rvagg Mar 31, 2016
dabe1d5
http: Corrects IPv6 address in Host header
mpotra Feb 19, 2016
8dcb82d
build: introduce ci targets for lint/benchmark
jbergstroem Mar 27, 2016
ec49fc8
net: improve socket.write() error message
phillipj Mar 31, 2016
d939152
doc: fix typo in fs writeSync param list
firedfox Apr 1, 2016
39de601
net: support DNS hints in createConnection()
cjihrig Apr 1, 2016
0928584
deps: upgrade npm to 3.8.3
othiym23 Mar 30, 2016
0dcb026
buffer: don't set `kNoZeroFill` flag in allocUnsafe
vkurchatkin Apr 1, 2016
d7987d9
meta: add "joining a wg" section to WORKING_GROUPS.md
mcollina Feb 29, 2016
82c2996
doc: refine child_process detach behaviour
eljefedelrodeodeljefe Feb 19, 2016
8d1d3bb
test: refactor http-end-throw-socket-handling
santigimeno Mar 12, 2016
33003a5
doc: consolidate timers docs in timers.markdown
bengl Mar 21, 2016
c06824b
doc: clarify that __dirname is module local
jasnell Apr 2, 2016
63e743d
doc: minor argument formatting in stream.markdown
jasnell Apr 2, 2016
8832be4
tools: remove disabling of already-disabled rule
Trott Apr 2, 2016
ba0b769
doc: add 'Command Line Options' to 'View on single page'
firedfox Apr 2, 2016
6fd26dc
doc: clarify stdout/stderr arguments to callback
jasnell Apr 2, 2016
64bf4b3
doc: document unspecified behavior for buf.write* methods
jasnell Mar 27, 2016
f739a12
test: fix error message checks in test-module-loading
jasnell Apr 1, 2016
8d96300
test: fix test-dns.js flakiness
Trott Apr 1, 2016
539cede
doc: note assert.throws() pitfall
Trott Apr 3, 2016
c60faf6
test: fix flaky test-net-socket-timeout-unref
Trott Mar 29, 2016
263222d
test: fix pummel test failures
Trott Apr 2, 2016
68bd702
doc: use HTTPS for links where possible
Trott Apr 2, 2016
3072546
path: fix win32.isAbsolute() inconsistency
mscdex Apr 3, 2016
3df16b1
test: explicitly set global in test-repl
Trott Apr 3, 2016
858b4b3
test: make arch available in status files
santigimeno Apr 1, 2016
ae2be27
test: be explicit about polluting of `global`
Trott Apr 2, 2016
c864edf
Merge branch 'nodejs/master' into chakracore-master
Apr 5, 2016
0cd4cb8
gyp: revert incorrect quote_cmd fix
Apr 4, 2016
313cec1
chakrashim: add test/addons dependency stubs
Apr 4, 2016
53c2d8e
test: skip null-buffer-neuter on node-chakracore
Apr 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gyp: revert incorrect quote_cmd fix 
Previously I had created a gyp tool fix to quote gyp action
command: microsoft/node-v0.12#1

It looks some related gyp code have changed. The fix is now incorrect.
cmd[0] contains both the action command and its arguments and the fix
quoted it to `"some_command arg_list"`. gyp now generates a "call" to
invoke the action, and it is invalid to `call "some_command arg_list"`.

The right approach is probably for people to ensure some_command is
correctly quoted in gyp file, rather than adding quote in gyp tool.

Anyway, the old issue does not exist now. Previously Node.js gyp action
command was `<(python)`, it is now `python`. So quotes no longer needed.

PR-URL: #52
Reviewed-By: Sandeep Agarwal <[email protected]>
  • Loading branch information
Jianchun Xu committed Apr 6, 2016
commit 0cd4cb887c2faacfa786a67e2018f6805612e6e2
2 changes: 0 additions & 2 deletions deps/npm/node_modules/node-gyp/gyp/pylib/gyp/generator/msvs.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions tools/gyp/pylib/gyp/generator/msvs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,6 @@ def _BuildCommandLineForRuleRaw(spec, cmd, cygwin_shell, has_input_path,
command = ['type']
else:
command = [cmd[0].replace('/', '\\')]
if quote_cmd:
command = ['"%s"' % i for i in command]
# Add call before command to ensure that commands can be tied together one
# after the other without aborting in Incredibuild, since IB makes a bat
# file out of the raw command string, and some commands (like python) are
Expand Down