This repository was archived by the owner on Oct 15, 2020. It is now read-only.
test: re-enable assert_throws_stack tests for node-chakracore#504
Merged
mike-kaufman merged 2 commits intonodejs:masterfrom Mar 28, 2018
Merged
Conversation
MSLaguana
approved these changes
Mar 28, 2018
jackhorton
approved these changes
Mar 28, 2018
Contributor
jackhorton
left a comment
jackhorton
left a comment
There was a problem hiding this comment.
Why did this originally fail?
Contributor
Author
The test changed upstream to output some additional output, so baseline was different. I just disabled this during the merge just to get merge unblocked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passes