This repository was archived by the owner on Oct 15, 2020. It is now read-only.
lib,test: stop using process.jsEngine#501
Merged
kfarnung merged 1 commit intonodejs:masterfrom Mar 21, 2018
Merged
Conversation
Contributor
Author
MSLaguana
approved these changes
Mar 19, 2018
kfarnung
force-pushed
the
jsengine
branch
4 times, most recently
from
f78c6a6 to
539db1d
Compare
jackhorton
approved these changes
Mar 20, 2018
Replace calls to process.jsEngine with property checks of the `process.versions` object. This doesn't address all of them, but makes a bit of progress. PR-URL: nodejs#501 Reviewed-By: Seth Brenith <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Jack Horton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace calls to process.jsEngine with property checks of the
process.versionsobject.This doesn't address all of them, but makes a bit of progress.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes