This repository was archived by the owner on Oct 15, 2020. It is now read-only.
test: update inspect Promise output#474
Merged
kfarnung merged 1 commit intonodejs:masterfrom Mar 9, 2018
Merged
Conversation
2 tasks
digitalinfinity
approved these changes
Feb 23, 2018
MSLaguana
approved these changes
Mar 1, 2018
Contributor
MSLaguana
left a comment
MSLaguana
left a comment
There was a problem hiding this comment.
I think it's worth adding a comment somewhere stating that this isn't actually the correct behavior, but otherwise it looks good to me.
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 9, 2018
PR-URL: nodejs#474 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 9, 2018
PR-URL: nodejs#474 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 9, 2018
PR-URL: nodejs#474 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 9, 2018
PR-URL: nodejs#474 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
Contributor
Author
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 9, 2018
PR-URL: nodejs#474 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 9, 2018
PR-URL: nodejs#474 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
PR-URL: nodejs#474 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 9, 2018
PR-URL: nodejs#474 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test