This repository was archived by the owner on Oct 15, 2020. It is now read-only.
test: update inspector skips#455
Merged
kfarnung merged 1 commit intonodejs:masterfrom Jan 29, 2018
Merged
Conversation
MSLaguana
approved these changes
Jan 29, 2018
Contributor
|
changes LGTM, CI failures seem unrelated. The arm build failure looks like it might be a config issue? |
Contributor
Author
|
The ARM build machines in the test CI haven't been updated yet. From the output it looks like the ARM compilers haven't been installed. I believe @joaocgreis was planning to take care of that this week. |
Reordered the list and removed a now passing test. PR-URL: nodejs#455 Reviewed-By: Jimmy Thomson <[email protected]>
kfarnung
force-pushed
the
inspector_tests
branch
from
dbf2916 to
25a3ac8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reordered the list and removed a now passing test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test