This repository was archived by the owner on Oct 15, 2020. It is now read-only.
build,test: various fixes to align with upstream#446
Closed
kfarnung wants to merge 0 commit intonodejs:masterfrom
Closed
build,test: various fixes to align with upstream#446kfarnung wants to merge 0 commit intonodejs:masterfrom
kfarnung wants to merge 0 commit intonodejs:masterfrom
Conversation
digitalinfinity
approved these changes
Jan 11, 2018
Contributor
digitalinfinity
left a comment
digitalinfinity
left a comment
There was a problem hiding this comment.
Seems reasonable
jackhorton
approved these changes
Jan 11, 2018
| ], | ||
| 'conditions' : [ | ||
| ['node_use_v8_platform=="true" and node_engine=="v8"', { | ||
| ['node_use_v8_platform=="true"', { |
Contributor
There was a problem hiding this comment.
I remember we had an issue where we were using v8_platform incorrectly -- I think @digitalinfinity looked into it? Wasn't this the gtest issue?
Contributor
Contributor
Author
There was a problem hiding this comment.
@digitalinfinity this one is already embedded inside a node_engine=="v8" condition, so this should be unnecessary. I think the bug you were seeing was caused by the unnecessary duplicate entry:
kfarnung
added a commit
that referenced
this pull request
Jan 12, 2018
PR-URL: #446 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jack Horton <[email protected]>
kfarnung
added a commit
that referenced
this pull request
Jan 12, 2018
PR-URL: #446 Reviewed-By: Hitesh Kanwathirtha <[email protected]> Reviewed-By: Jack Horton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While preparing the v8.x branch I noticed a few oddities in the node.gyp file. This change attempts to bring the file more closely into alignment with upstream.
I also removed an orphaned test status entry.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build, test